Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

  • Change Manager (CM): Rodrigo Nascimento (CTO); Is responsible for assessing the impact of a change, to identify any risks, and make a recommendation for approval or rejection of a release.

  • Delegated Change Manager (DCM): Anyone in the organization that is listed on the letter of delegation from the Change Manager; Is a delegation from Change Manager and has the same responsibilities. Letter available at: https://rocketchat.atlassian.net/wiki/spaces/Handbook/pages/74089694/Delegation+letter

  • Code Owners (CO): Members from github teams as assigned on https://github.com/orgs/RocketChat/teams ; Responsible for checking modifications to code that impact a given github repository and its code.

  • Engineer from internal squads: Any engineer from rocket.chat team that is listed on https://theorg.com/org/rocket-chat/org-chart .

  • QA Squad: Any member of internal squads with a QA role.

...

  1. All proposed changes must be submitted as a GitHub Pull Request (PR) and follow its General Instructions and Handling procedure (https://handbookrocketchat.rocketatlassian.chat/departments-operations/research-and-development/engineering/development/pr-general-instructions-and-handlingnet/wiki/spaces/Handbook/pages/74055763/PR+General+Instructions+and+Handling )

  2. A peer review is required for all the submitted PR following the documented Review Guidelines (https://handbookrocketchat.rocketatlassian.chat/departments-operations/research-and-development/engineering/development/review-guidelinesnet/wiki/spaces/Handbook/pages/74088585/Review+Guidelines ). PR approval or comments will be placed on github.

  3. Code Owners review will be required in case the change impacts multiple areas of the code and will also be performed based on our Review Guidelines (https://handbookrocketchat.rocketatlassian.chat/departments-operations/research-and-development/engineering/development/review-guidelinesnet/wiki/spaces/Handbook/pages/74088585/Review+Guidelines ). PR approval or comments will be placed on github.

  4. After Peer Review and/or Code Owners review, an approved PR can be merged into the development branch.

  5. All changes of a given period merged into the development branch, will be bundled into a release-related PR for Major, Minor, Security or Patch Release Pull Request on Github by any engineer from internal squads. PS: Classification for different releases is available at: https://handbookrocketchat.rocket.chat/departments-operations/research-and-development/release-cycleatlassian.net/wiki/spaces/Handbook/pages/29491377/Release+Cycle

  6. Change Manager or Delegated Change Manager approval is required on any given release-related PR.

  7. After approval a release-related PR will be merged into the Master branch and can become available for our customers on self-hosted and SaaS products.

...